Fixing formatting of certain kinds of ranges of ranges. #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase, I've fixed the |
brevzin
force-pushed
the
fix-fmt-range-of-range
branch
from
deb5a27 to
36ab74f
Compare
Done 👍 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you had a range of
R, whereRis a const-iterable range, then theformatterwould expect its argument to be passed as aconst R&but the implementation would end up passing anR&instead (thefmt_ref_viewcase fails to compile on master).But we don't need to deduce the range and check that it has the right const-ness, we can just declare it to have the expected type instead. If that type is
const R&, then that just works.