Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2681
The working flow:
is_utf8()
callsdetail::print
that specifically converts to UTF-16 and callsWriteConsoleW
is_utf8()
callsfwrite_fully
The broken flow:
fputs
The fix:
is_utf8()
calldetail::print
is_utf8()
keep callingfputs
, asfwrite_fully
is not exportedThis is tested on Windows only. On Windows
fputs
does not do any magic, and color sequences are processed byWriteConsole
. I'm not sure if on other platformfputs
processes these ANSI escape sequences, orfwrite
will also do.