Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose headers depending on special configuration option #2651

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Expose headers depending on special configuration option #2651

merged 1 commit into from
Dec 19, 2021

Conversation

alexezeder
Copy link
Contributor

@alexezeder alexezeder commented Dec 13, 2021 •
edited
Loading

Originated from #2644.

Special FMT_SYSTEM_HEADERS (I didn't come up with a better name) CMake option added. It's disabled by default.

vitaut
vitaut requested changes Dec 18, 2021
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good but I don't think the option should be tied to {fmt}'s use as a subproject. I suggest making it off by default unconditionally instead.

@alexezeder alexezeder force-pushed the expose_headers_as_system branch from b90b7c5 to 18f96ae Compare December 18, 2021 15:49
@alexezeder alexezeder requested a review from vitaut December 18, 2021 16:21
@vitaut vitaut merged commit c5aafd8 into fmtlib:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexezeder @vitaut