[doc] FMT_STRING supports C++14 and no-op in C++11 #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Nov 27, 2021
doc/api.rst
Outdated
| @@ -69,6 +69,7 @@ checked at compile time in C++20. To pass a runtime format string wrap it in | |||
| Compile-time Format String Checks | |||
| --------------------------------- | |||
|
|
|||
| Requires C++14 and it's no-op in C++11. | |||
There was a problem hiding this comment.
Let's move this to the end of the paragraph because we should first say what FMT_STRING is. Also minor wording tweak:
Requires C++14 and is a no-op in C++11.
There was a problem hiding this comment.
Thanks for the brilliant suggestion! It's clearer than before.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I want to use FMT_STRING in a C++11 project and found that FMT_STRING doesn't support C++11.
It emits exception instead of compile time error in this demo.
Then I found that in #2039, @vitaut stated that FMT_STRING a no-op in C++11, but there is no documentation specify this limitation.
I decide to put the requirement in the first line, so one will find the limitation immediately.
So here's my simple PR. Hopefully it doesn't break google's documentation guide line.