Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting of function pointers, member function pointers, member object pointers... #2610

Merged
merged 6 commits into from
Nov 23, 2021
Merged

Formatting of function pointers, member function pointers, member object pointers... #2610

merged 6 commits into from
Nov 23, 2021

Conversation

AlexGuteniev
Copy link
Contributor

...is not supported

Resolves #2609

AlexGuteniev
AlexGuteniev commented Nov 23, 2021
View reviewed changes
include/fmt/core.h Outdated Show resolved Hide resolved
vitaut
vitaut requested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good but let's simplify this per the comment inline.

include/fmt/core.h Outdated Show resolved Hide resolved
@AlexGuteniev AlexGuteniev requested a review from vitaut November 23, 2021 20:10
@vitaut vitaut merged commit a3ab36c into fmtlib:master Nov 23, 2021
@vitaut
Copy link
Contributor

vitaut commented Nov 23, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting of function pointers should be disallowed
2 participants
@AlexGuteniev @vitaut