Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static to a table #2509

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Add static to a table #2509

merged 1 commit into from
Sep 24, 2021

Conversation

jk-jeon
Copy link
Contributor

@jk-jeon jk-jeon commented Sep 22, 2021

As mentioned here and here, GCC fails to optimize non-static constexpr table initialization, so it is better to add static keyword here.

@vitaut vitaut merged commit 9c57357 into fmtlib:master Sep 24, 2021
@vitaut
Copy link
Contributor

vitaut commented Sep 24, 2021

Thanks!

PoetaKodu pushed a commit to pacc-repo/fmt that referenced this pull request Nov 11, 2021
@jk-jeon @PoetaKodu
Add static to a table (fmtlib#2509)
018eaaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jk-jeon @vitaut