Fix an odr violation in ranges.h #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Sep 2, 2021
test/ranges-odr-test.cc
Outdated
Comment on lines
7
to
10
| // | ||
| // Copyright (c) 2018 - present, Remotion (Igor Schulz) | ||
| // All Rights Reserved | ||
| // {fmt} support for ranges, containers and types tuple interface. |
There was a problem hiding this comment.
This part only applies to ranges.h, please remove.
There was a problem hiding this comment.
Removed, and explained why this content.
|
Thanks for the PR! |
PoetaKodu
pushed a commit
to pacc-repo/fmt
that referenced
this pull request
Nov 11, 2021
* Add a testcase demonstrating ODR violation in ranges.h * Fix ODR violation in ranges.h * Fix comments Co-authored-by: Pierre-Antoine Lacaze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.