suppress unused variable warnings #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An arguably better method for suppressing unused variable warnings. The `(void)var` method does not work on many intel compiilers. This is from Herb Sutter's blog post https://herbsutter.com/2009/10/18/mailbag-shutting-up-compiler-warnings/
|
Thanks for the PR but do you actually get a warning or is it mostly theoretical? |
|
I actually get warnings on my Intel builds. |
vitaut
reviewed
Jun 26, 2021
vitaut
reviewed
Jun 29, 2021
include/fmt/core.h
Outdated
| // `(void)var` method does not work on many intel compilers. This is | ||
| // from Herb Sutter, "Shutting up compiler warnings", | ||
| // https://herbsutter.com/2009/10/18/mailbag-shutting-up-compiler-warnings/ | ||
| template<class T> void ignore_unused( const T& ) { } |
There was a problem hiding this comment.
Could you apply clang-format?
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An arguably better method for suppressing unused variable warnings. The
(void)varmethod does not work on many intel compiilers.This is from Herb Sutter's blog post https://herbsutter.com/2009/10/18/mailbag-shutting-up-compiler-warnings/