CI: set up multi-thread build for all platforms #2336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few points for this PR, as usual:
I use
--parallel
option ofcmake --build
subcommand to pass threads count in a cross-compile way, it's available with CMake 3.12+, all containers of GitHub Actions have 3.20+each platform use different approaches to get the number of threads:
nproc
for Linux, returns2
sysctl -n hw.logicalcpu
for macOS, since there is nonproc
, returns3
(Get-CimInstance Win32_ComputerSystem).NumberOfLogicalProcessors
for Windows, returns2
of course, these values could be hardcoded according to Supported runners and hardware resources, but since we can retrieve this info, hardcoding is not needed.
my results show a decrease of build time for all platforms, but let's look at results for this PR.