Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: hide private symbols by default #2301

Merged
merged 1 commit into from
May 21, 2021

Conversation

sergiud
Copy link
Contributor

@sergiud sergiud commented May 21, 2021

Enable -fvisibility=hidden and -fvisibility-inlines-hidden by default in CMakeLists.txt. Reduces the size of the shared library from 244K to 212K. Allow users to override the default choice.

Related to #2299.

@vitaut vitaut merged commit 128cbde into fmtlib:master May 21, 2021
@vitaut
Copy link
Contributor

vitaut commented May 21, 2021

Thank you!

@sergiud sergiud deleted the cmake-hide-private-symbols branch May 21, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants