Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang 8.0.x compilation error #2291

Closed
wants to merge 1 commit into from
Closed

fix clang 8.0.x compilation error #2291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fmt/os.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ struct ostream_params {
};
} // namespace detail

static constexpr detail::buffer_size buffer_size;
static constexpr detail::buffer_size buffer_size{};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short comment clarifying that {} is a workaround for gcc 8, preferably with a link to the bug report.


/** A fast output stream which is not thread-safe. */
class ostream final : private detail::buffer<char> {
Expand Down