Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a formatter specialization for std::error_code. #2270

Merged
merged 1 commit into from
May 9, 2021
Merged

Add a formatter specialization for std::error_code. #2270

merged 1 commit into from
May 9, 2021

Conversation

phprus
Copy link
Contributor

@phprus phprus commented May 8, 2021

Discussion: #2269

@phprus phprus mentioned this pull request May 8, 2021
Closed
@phprus phprus force-pushed the format-error_code branch from 41ebf7f to 0319174 Compare May 8, 2021 12:37
vitaut
vitaut requested changes May 8, 2021
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good in general, a few comments inline.

include/fmt/format.h Outdated Show resolved Hide resolved
test/compile-test.cc Outdated Show resolved Hide resolved
test/format-test.cc Outdated Show resolved Hide resolved
@phprus phprus force-pushed the format-error_code branch 2 times, most recently from 434fb5d to 2b4e5a3 Compare May 8, 2021 14:31
@phprus phprus requested a review from vitaut May 8, 2021 14:39
vitaut
vitaut requested changes May 8, 2021
View reviewed changes
include/fmt/os.h Outdated Show resolved Hide resolved
test/compile-test.cc Outdated Show resolved Hide resolved
test/os-test.cc Outdated Show resolved Hide resolved
@phprus phprus force-pushed the format-error_code branch from 2b4e5a3 to 41bb4f6 Compare May 9, 2021 07:28
@phprus phprus requested a review from vitaut May 9, 2021 07:48
@vitaut vitaut merged commit 4211d86 into fmtlib:master May 9, 2021
@vitaut
Copy link
Contributor

vitaut commented May 9, 2021

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut Awaiting requested review from vitaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phprus @vitaut