Try to suppress MVSC warn of narrowing #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to suppress MVSC warn of narrowing > fmt\test\format-test.cc(774): warning C4838: conversion from 'int' to 'wchar_t' requires a narrowing conversion
and change the mask target into unsigned int Note: This is odd because the `std::make_unsigned_t` is supposed to bethere in c++14.
vitaut
requested changes
Apr 13, 2021
test/format-test.cc
Outdated
| '+' | (1 << fmt::detail::num_bits<char>()), L'}', 0}; | ||
| '+' | static_cast<wchar_t>( | ||
| 1 << fmt::detail::num_bits<char>() | ||
| & static_cast<typename std::make_unsigned<int>::type >(-1) ), |
There was a problem hiding this comment.
The second static cast and & are not needed, please remove.
There was a problem hiding this comment.
May I ask if it's unneccessary always or just in this case?
There was a problem hiding this comment.
I don't see why it was added in the first place here. It has no effect.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to suppress MVSC warn of narrowing at