-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang keeps complain it ignores __declspec(dllexport) of basic_data<void> template instantitation definition in format.cc #2220
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0ad4dad
Clang keeps complain it ignores __declspec(dllexport)
denchat 28882fa
Add the template instantiation declaration
denchat 81aaff7
Fix incorrect namespace in previous commit
denchat 70258cb
Move FMT_INSTANTIATION_DEF_API deletion into WIN32
denchat 0e3c282
Try remove FMT_INSTANTIATION_DEF_API
denchat 1bb8044
Fix removing entire declaration
denchat c91cb64
Restore the original behavior
denchat 66f6f54
D61118 : mark dllexport on extern template only
denchat 9687bce
Move FMT_INSTANTIATION_DEF_API to the declaration
denchat 8658826
Rename FMT_INSTANTIATION_DEF_API
denchat e2c1a2c
Rename FMT_INSTANTIATION_DECL_API
denchat 400a0a5
Add a comment about clang
denchat f0269f9
do clang-formatting the comment
denchat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a short comment saying that clang doesn't allow
__declspec(dllexport)
here.