Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress redef warning of _CRT_SECURE_NO_WARNINGS if any. #2218

Merged
merged 2 commits into from
Apr 8, 2021
+1 −1
Merged

Suppress redef warning of _CRT_SECURE_NO_WARNINGS if any. #2218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf8895c
Suppress redef warning of _CRT_SECURE_NO_WARNINGS
denchat Apr 8, 2021
d3f714d
Make it always on. Remove the WIN32 check
denchat Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/chrono-test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
// For the license information refer to format.h.

#ifdef WIN32
Copy link
Contributor

@vitaut vitaut Apr 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of the WIN32 check for simplicity. There is no harm in having the macro always defined.

# define _CRT_SECURE_NO_WARNINGS
# ifndef _CRT_SECURE_NO_WARNINGS
# define _CRT_SECURE_NO_WARNINGS
# endif
#endif

#include "fmt/chrono.h"
Expand Down