Fix fmt::get with function pointers for some GCC versions and legacy Clang
#2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexezeder
force-pushed
the
fix/issue-2140
branch
from
547e6d1 to
039313b
Compare
vitaut
requested changes
Feb 23, 2021
include/fmt/format.h
Outdated
Comment on lines
3836
to
3839
| template <typename T> | ||
| #if FMT_CLANG_VERSION && FMT_CLANG_VERSION < 700 | ||
| enable_if_t<!std::is_function<T>::value, const void*> | ||
| #else | ||
| const void* | ||
| #endif | ||
| ptr(const T* p) { | ||
| return p; | ||
| } |
There was a problem hiding this comment.
Can we change this to
template <typename T>
const void* ptr(T p) {
static_assert(std::is_pointer<T>::value, "");
return detail::bit_cast<const void*>(p);
}and remove the ptr(T (*fn)(Args...)) overload below?
There was a problem hiding this comment.
Yes, we can. Another great code simplification.
fixes fmtlib#2140 - some GCC versions decay function pointers to `const void*`, exactly like MSVC does - legacy Clang (prior to 7.0) treats function pointers also as `const T*` pointers, but unable to convert them
alexezeder
force-pushed
the
fix/issue-2140
branch
from
039313b to
9e3a2ed
Compare
|
This is unrelated to this PR, but maybe this overload should also be added later: inline const void* ptr(std::nullptr_t) {
return nullptr;
} |
I don't think it's necessary because |
sthagen
added a commit
to sthagen/fmtlib-fmt
that referenced
this pull request
Feb 23, 2021
fix `fmt::get` for some GCC versions and legacy Clang (fmtlib#2144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2140.
Some points:
const T*pointers but unable to convert themconst void*, exactly like MSVC doesinlinespecifiers removed because all functions are templates