Use gcc-10.2 instead of gcc-10.1 on CI, also fix one problem #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the problem was not detected by test because of wrong gcc-10 minor version on CI
alexezeder
force-pushed
the
fix/wrong_gcc_10_minor_version_on_CI
branch
from
7568ddc to
92835d3
Compare
vitaut
reviewed
Jan 23, 2021
| include: | ||
| - cxx: g++-4.8 | ||
| install: sudo apt install g++-4.8 | ||
| os: ubuntu-18.04 |
There was a problem hiding this comment.
Can we avoid explicitly specifying ubuntu-18.04 here and below? Won't it get the default from os above?
There was a problem hiding this comment.
My tests with Actions show that no, it won't be defaulted to ubuntu-18.04, it's just empty in those cases.
Here is the CI run for config without explicit os.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I missed that
ubuntu-18.04image on CI has GCC-10.1 installed, so CI is unable to build compile-time formatting tests because they require GCC-10.2+.fmt/include/fmt/format.h
Lines 286 to 287 in 9c418bc
fmt/test/compile-test.cc
Lines 190 to 191 in 9c418bc
So I just switched the Ubuntu image to
ubuntu-20.04for theg++-10compiler with C++20 standard. TheCompileTimeFormattingTesttests do run now, it's checked by failing CI build with false commit on CI.Also, this PR fixes the problem that was not detected on CI because of the wrong GCC-10 minor version.