Add build variable: FMT_MASTER_PROJECT #2099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Jan 16, 2021
CMakeLists.txt
Outdated
| if (CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR) | ||
| set(MASTER_PROJECT ON) | ||
| message(STATUS "CMake version: ${CMAKE_VERSION}") | ||
| if(NOT DEFINED FMT_MASTER_PROJECT) |
There was a problem hiding this comment.
nit: please add a space after if for consistency
CMakeLists.txt
Outdated
Comment on lines
14
to
15
| else () | ||
| set(FMT_MASTER_PROJECT OFF) |
There was a problem hiding this comment.
I suggest setting FMT_MASTER_PROJECT to OFF outside of if as before and removing the else branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build variable
FMT_MASTER_PROJECTis added so user can build and install fmt library even if the project is included as a submodule. See discussion: #2098 (comment).I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.