Reenable support for fallback formatter to join (#2040) #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Dec 6, 2020
include/fmt/ostream.h
Outdated
| @@ -147,6 +147,19 @@ struct fallback_formatter<T, Char, enable_if_t<is_streamable<T, Char>::value>> | |||
| return std::copy(buffer.begin(), buffer.end(), ctx.out()); | |||
| } | |||
| }; | |||
|
|
|||
| template <typename It, typename Sentinel, typename Char> | |||
| struct fallback_formatter<arg_join<It, Sentinel, Char>, Char> | |||
There was a problem hiding this comment.
fallback_formatter is not an extension point so it shouldn't be specialize for arg_join. Instead make formatter specialization enabled if there is a fallback formatter for the element type as it is done for ranges.
There was a problem hiding this comment.
Ok hope it is better now.
kamibo
force-pushed
the
join_fallback_formatter
branch
from
742abd6 to
ca5414c
Compare
vitaut
requested changes
Dec 7, 2020
include/fmt/format.h
Outdated
| : formatter<typename std::iterator_traits<It>::value_type, Char> { | ||
| struct formatter<arg_join<It, Sentinel, Char>, Char> { | ||
| using value_type = typename std::iterator_traits<It>::value_type; | ||
| using context_type = basic_format_context<arg_join<It, Sentinel, Char>, Char>; |
include/fmt/format.h
Outdated
| using context_type = basic_format_context<arg_join<It, Sentinel, Char>, Char>; | ||
| using formatter_type = | ||
| conditional_t<has_formatter<value_type, format_context>::value, | ||
| typename context_type::template formatter_type<value_type>, |
There was a problem hiding this comment.
Just use formatter<value_type, Char> here.
include/fmt/format.h
Outdated
Comment on lines
3724
to
3731
| using value_type = typename std::iterator_traits<It>::value_type; | ||
| using context_type = basic_format_context<arg_join<It, Sentinel, Char>, Char>; | ||
| using formatter_type = | ||
| conditional_t<has_formatter<value_type, format_context>::value, | ||
| typename context_type::template formatter_type<value_type>, | ||
| detail::fallback_formatter<value_type, Char>>; | ||
|
|
||
| formatter_type formatting; |
kamibo
force-pushed
the
join_fallback_formatter
branch
from
ca5414c to
94383a5
Compare
vitaut
requested changes
Dec 7, 2020
kamibo
force-pushed
the
join_fallback_formatter
branch
from
94383a5 to
34c404c
Compare
vitaut
reviewed
Dec 8, 2020
vitaut
requested changes
Dec 8, 2020
kamibo
force-pushed
the
join_fallback_formatter
branch
from
34c404c to
6d9892f
Compare
|
Merged, thanks. |
|
Thanks for your time and what you have done so far. It is really great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.