🎨 [ci] Specify the exact version of clang to use #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgopel
changed the title
Problem: - The version of clang to use is specified only as `clang++`. This is inconsistent with the specifications for gcc and exposed to unexpected failure if the default changes. Solution: - Specify the exact version of clang to use. I chose `clang++-9` as that is the version that `clang++` is currently resolving to.
jgopel
force-pushed
the
specify-clang-version
branch
from
16fdb28 to
031246a
Compare
|
Good idea, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
clang++. This isinconsistent with the specifications for gcc and exposed to unexpected
failure if the default changes.
Solution:
clang++-9as thatis the version that
clang++is currently resolving to.I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.