Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use memchr for searching for '%' in printf format string #1984

Merged
merged 3 commits into from
Nov 8, 2020
Merged

use memchr for searching for '%' in printf format string #1984

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2de072
use memchr for searching for '%' in printf format string
rimathia Nov 5, 2020
e662999
remove manual linear search clause
rimathia Nov 8, 2020
0698d10
replace unnecessary continue with break, get rid of now redundant it …
rimathia Nov 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion include/fmt/printf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,8 +474,13 @@ OutputIt basic_printf_context<OutputIt, Char>::format() {
const Char* end = parse_ctx_.end();
auto it = start;
while (it != end) {
if (!detail::find<false, Char>(it, end, '%', it)) {
it = end;
rimathia marked this conversation as resolved.
Show resolved Hide resolved
}
if (it == end) {
continue;
}
char_type c = *it++;
if (c != '%') continue;
if (it != end && *it == c) {
out = std::copy(start, it, out);
start = ++it;
Expand Down