Fix implicit signedness conversion warning #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Please post the warning and repro details including compiler version. Also it looks like the description was copied from a wrong PR. |
jgopel
force-pushed
the
fix-sign-conversion-warning
branch
from
364475e to
1ce1507
Compare
|
Updated in the commit notes and here in the original comment. |
vitaut
requested changes
Oct 28, 2020
test/std-format-test.cc
Outdated
| @@ -111,7 +111,7 @@ template <> struct std::formatter<S> { | |||
| char c = get_char(); | |||
| if (!isdigit(c) || (++iter, get_char()) != '}') | |||
| throw format_error("invalid format"); | |||
| width_arg_id = c - '0'; | |||
| width_arg_id = static_cast<decltype(width_arg_id)>(c - '0'); | |||
There was a problem hiding this comment.
Please use fmt::detail::to_unsigned instead of a cast.
Problem:
- On Apple clang 11.0.3 (clang-1103.0.32.62), pedantic mode compilation
generates the following error:
test/std-format-test.cc:114:22: error: implicit conversion changes
signedness: 'int' to 'size_t' (aka 'unsigned long')
[-Werror,-Wsign-conversion]
width_arg_id = c - '0';
~ ~~^~~~~
Solution:
- Use a `to_unsigned` to make the conversion explicit. This is
guaranteed to be safe due to the check before the ASCII-to-int
conversion.
jgopel
force-pushed
the
fix-sign-conversion-warning
branch
from
1ce1507 to
d3d84cd
Compare
vitaut
changed the title
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On Apple clang 11.0.3 (clang-1103.0.32.62), pedantic mode compilation
generates the following error:
test/std-format-test.cc:114:22: error: implicit conversion changes
signedness: 'int' to 'size_t' (aka 'unsigned long')
[-Werror,-Wsign-conversion]
width_arg_id = c - '0';
~ ~~^~~~~
Solution:
to_unsignedto make the conversion explicit. This isguaranteed to be safe due to the check before the ASCII-to-int
conversion.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.