Range support #1953
Merged
Range support #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-quinones
force-pushed
the
ranges
branch
from
404fb19 to
bffd834
Compare
vitaut
requested changes
Oct 25, 2020
include/fmt/ranges.h
Outdated
|
|
||
| # define FMT_DECLTYPE_RETURN(val) \ | ||
| ->decltype(val) { return val; } \ | ||
| static_assert(true, "a") |
There was a problem hiding this comment.
What is this static assert for?
There was a problem hiding this comment.
the static assert makes it so that a semi colon is required after the macro, which mostly just helps clang-format handle the code better. the "a" is to silence a clang-tidy warning to replace the statement with a unary static assert. mostly a habit of mine but i'm not sure if it's needed here
sarah-quinones
force-pushed
the
ranges
branch
from
bffd834 to
8f39926
Compare
vitaut
requested changes
Oct 27, 2020
include/fmt/core.h
Outdated
| @@ -1207,6 +1211,11 @@ template <typename Context> struct arg_mapper { | |||
| return 0; | |||
| } | |||
|
|
|||
| template <typename T, std::size_t N> | |||
| FMT_CONSTEXPR auto map(T const (&values)[N]) -> T const (&)[N] { | |||
sarah-quinones
force-pushed
the
ranges
branch
from
8f39926 to
c317045
Compare
sarah-quinones
force-pushed
the
ranges
branch
from
c317045 to
17070bf
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.
this PR adds support for ranges when the
begin/endmembers are not const. this is done by copying the range, since in those cases the range is likely to be a view, so a copy is cheap. if we want to be more restrictive, we can instead only do so when the object isnothrow_copy_constructible.instead of using
begin/endmember functions, i've chosen to extend support for when they're found by argument dependent lookup, with a special case for C arrays. this is to be more consistent with the rest of the language, as the same is done for c++20 ranges and range-for loops.an alternative to copying the range would be to forward the arguments, rather than capturing them as
const&. but i'm not sure if that would be preferable.