-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export assert_fail with FMT_API. This fixes dll build. #1446
Conversation
include/fmt/format-inl.h
Outdated
@@ -55,7 +55,7 @@ inline fmt::internal::null<> strerror_s(char*, std::size_t, ...) { return {}; } | |||
FMT_BEGIN_NAMESPACE | |||
namespace internal { | |||
|
|||
FMT_FUNC void assert_fail(const char* file, int line, const char* message) { | |||
FMT_API FMT_FUNC void assert_fail(const char* file, int line, const char* message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think FMT_API
is not needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, maybe. First, I thought header goes to users, but it seems it is fmt internal stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, tested, works without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for the opt-in header-only mode and effectively an internal header.
Thanks! |
I just pulled the most recent build 7.0.3, but still see the same problem mentioned here. 1>------ Rebuild All started: Project: TMP, Configuration: Debug Win32 ------ |
See #1445
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.