User-defined literals improvements #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR. All looks good but I'd rather not have a using directive in a header even as an opt-in. If users want something like that they can create a small wrapper header. |
vitaut
reviewed
Aug 1, 2019
|
|
||
| template <typename... Args> | ||
| auto operator()(Args&&... args) const | ||
| -> decltype(format(str, std::forward<Args>(args)...)) { | ||
| std::basic_string<Char> operator()(Args&&... args) const { |
|
Fair enough, I've rebased the branch to drop those two commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.
This is a few couple improvements to literals formatting API.
udl_formatter.basic_string_viewto store the format string and argument name instead of raw character pointers.constexpr.Adds the possibility of definingFMT_USING_LITERALSto allow all code at a project level to use the_formatand_aoperator.