Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove const qualification in compile-time checks #1230

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

jackoalan
Copy link
Contributor

A regression appeared in dd8cc8b for compile-time checking of const references.

Prior to dd8cc8b, all callers of make_args_checked had the equivalent of remove_const_t and remove_reference_t via parameter type deduction. Now only remove_reference_t is present which means custom type formatter specializations will not be selected unless they have been explicitly specialized with a const type. I am assuming that this is not the intended behavior and have added remove_const_t in addition to remove_reference_t.

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

@vitaut vitaut merged commit 699fe8e into fmtlib:master Jul 15, 2019
@vitaut
Copy link
Contributor

vitaut commented Jul 15, 2019

Thanks!

@jackoalan jackoalan deleted the no-const-compile-check branch July 15, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants