Remove const qualification in compile-time checks #1230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression appeared in dd8cc8b for compile-time checking of const references.
Prior to dd8cc8b, all callers of
make_args_checked
had the equivalent ofremove_const_t
andremove_reference_t
via parameter type deduction. Now onlyremove_reference_t
is present which means custom type formatter specializations will not be selected unless they have been explicitly specialized with a const type. I am assuming that this is not the intended behavior and have addedremove_const_t
in addition toremove_reference_t
.I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.