Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists.txt missing leading dash for mingw big object compile flag check #2540

Closed
cc2x opened this issue Oct 9, 2021 · 1 comment
Closed

CMakeLists.txt missing leading dash for mingw big object compile flag check #2540

cc2x opened this issue Oct 9, 2021 · 1 comment

Comments

@cc2x
Copy link

cc2x commented Oct 9, 2021

in the CMakeLists.txt file, the MINGW check shows this:

check_cxx_compiler_flag("Wa,-mbig-obj" FMT_HAS_MBIG_OBJ)

shouldn't the compiler flag string start with a dash?

check_cxx_compiler_flag("-Wa,-mbig-obj" FMT_HAS_MBIG_OBJ)

I discovered this when trying to build develutionx with mingw. cmake was telling me it failed on fmt's big object check. I made this locally and it no longer showed a failure for this compiler option.
vitaut added a commit that referenced this issue Oct 9, 2021
@vitaut
Fix compiler flag check (#2540)
1e96e01
@vitaut
Copy link
Contributor

vitaut commented Oct 9, 2021

Fixed in 1e96e01, thanks for reporting.

@vitaut vitaut closed this as completed Oct 9, 2021
Iniesta8 pushed a commit to jhnc-oss/fmt that referenced this issue Oct 28, 2021
@vitaut @Iniesta8
Fix compiler flag check (fmtlib#2540)
81b8878
PoetaKodu pushed a commit to pacc-repo/fmt that referenced this issue Nov 11, 2021
@vitaut @PoetaKodu
Fix compiler flag check (fmtlib#2540)
91deddf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @cc2x