-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization issue in vwindows_error #2274
Comments
And SEH exception:
|
For test |
I have implemented a prototype solution using utf8-ready error_category. |
A separate error category sounds like a good idea. |
Separate error category need only for Windows. |
phprus
added a commit
to phprus/fmt
that referenced
this issue
May 9, 2021
Merged
Done: #2275 |
phprus
added a commit
to phprus/fmt
that referenced
this issue
May 10, 2021
phprus
added a commit
to phprus/fmt
that referenced
this issue
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Microsoft STL system error category use
FormatMessageA
to make error description (https://github.com/microsoft/STL/blob/a8efb53f4e571957671226271da20deb1e3832b8/stl/src/syserror_import_lib.cpp#L49).On non-English Windows,
std::system_category(). message()
returns a result other thanformat_windows_error
.Possible solution: Create custom utf8-ready
error_category
for using in vwindows_error (https://github.com/fmtlib/fmt/blob/master/src/os.cc#L105)Failed tests (Russian Windows 7 SP1):
The text was updated successfully, but these errors were encountered: