New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plus flag formatting with locale is broken #2133

Closed

mp-t opened this issue Feb 12, 2021 · 1 comment

mp-t commented Feb 12, 2021 •

edited

Loading

fmt::format(std::locale("en_US.UTF-8"), "{:+L}", 100); produces an out-of-bounds memory access and wrong output.

Possible output: "-100" or ",100" depening on the fmt version.
Expected output: "100"

The text was updated successfully, but these errors were encountered:

vitaut changed the title ~~Format with locale is broken.~~ Plus flag formatting with locale is broken.

vitaut changed the title ~~Plus flag formatting with locale is broken.~~ Plus flag formatting with locale is broken

vitaut added a commit that referenced this issue


          Fix handling of the + flag with locales (#2133)

ee0fed6

Contributor

vitaut commented Feb 13, 2021

Fixed '+' handling with locale in ee0fed6. Thanks for reporting.

vitaut closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment