-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FMT_ENFORCE_COMPILE_STRING broken in 7.1.2 with format-inl.h #2002
Comments
Could you submit a PR to fix those? |
I'm working on it and have a patch for just those files, but I've discovered a number of other places with issues in chrono.h that are much trickier. Do you know why the format strings there are given in the form of constant char arrays? ie |
This is to handle the case when |
Interesting. Is there any reason it would be bad to replace these with FMT_STRING("...") equivalents? |
I've also discovered that using FMT_STRING() with fmt::format in color-test.cc is giving me
|
I don't think it will work.
Please don't change tests, only public headers. |
#2006 |
Update: Got it working by manually calling vformat_to to avoid the check enabled by FMT_ENFORCE_COMPILE_STRING. |
Co-authored-by: Walter Gray <[email protected]>
I don't think it's worth the trouble but a PR to add one test that checks that |
Several lines in format-inl.h do not use FMT_STRING, which causes static assertion failures with FMT_ENFORCE_COMPILE_STRING.
The text was updated successfully, but these errors were encountered: