Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC 2019 warnings "conversion from 'unsigned __int64' to 'size_t', possible loss of data" #1935

Closed
moiwi opened this issue Oct 15, 2020 · 2 comments

Comments

@moiwi
Copy link
Contributor

moiwi commented Oct 15, 2020

Commit 41d97e1 causes several MSVC 2019 warnings with "to_unsigned(size)":
format.h(1845,57): warning C4244: 'argument': conversion from 'unsigned __int64' to 'size_t', possible loss of data (compiling source file format.cc)
format.h(1846,56): warning C4244: 'argument': conversion from 'unsigned __int64' to 'size_t', possible loss of data (compiling source file format.cc)
format.h(1863,32): warning C4244: 'argument': conversion from 'unsigned __int64' to 'size_t', possible loss of data (compiling source file format.cc)
format.h(1876,32): warning C4244: 'argument': conversion from 'unsigned __int64' to 'size_t', possible loss of data (compiling source file format.cc)
format.h(1891,30): warning C4244: 'argument': conversion from 'unsigned __int64' to 'size_t', possible loss of data (compiling source file format.cc)

@Kaaserne
Copy link
Contributor

Same here:

format.h(1845): warning C4244: 'argument': conversion from 'unsigned __int64' to 'size_t', possible loss of data [D:\a\cpp-lazy\cpp-lazy\build\install\_deps\fmt-build\fmt.vcxproj]

@vitaut
Copy link
Contributor

vitaut commented Oct 18, 2020

Should be fixed in f468b20.

@vitaut vitaut closed this as completed Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants