Skip to content

Commit

Permalink
Small fixes for some issues with modules builds (#4152)
Browse files Browse the repository at this point in the history
* Avoid module export of member function definitions.

* Do not #include intrinsics header into module purview.
  • Loading branch information
kamrann authored Sep 4, 2024
1 parent 565461a commit b4aea98
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion include/fmt/base.h
Original file line number Diff line number Diff line change
Expand Up @@ -2465,7 +2465,6 @@ inline void vprint_mojibake(FILE*, string_view, const format_args&, bool) {}
} // namespace detail

// The main public API.
FMT_BEGIN_EXPORT

template <typename Char>
FMT_CONSTEXPR void parse_context<Char>::do_check_arg_id(int arg_id) {
Expand All @@ -2484,6 +2483,8 @@ FMT_CONSTEXPR void parse_context<Char>::check_dynamic_spec(int arg_id) {
static_cast<compile_parse_context<Char>*>(this)->check_dynamic_spec(arg_id);
}

FMT_BEGIN_EXPORT

// An output iterator that appends to a buffer. It is used instead of
// back_insert_iterator to reduce symbol sizes and avoid <iterator> dependency.
template <typename T> class basic_appender {
Expand Down
2 changes: 1 addition & 1 deletion include/fmt/format.h
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ FMT_END_NAMESPACE
# endif
#endif

#if FMT_MSC_VERSION
#if FMT_MSC_VERSION && !defined(FMT_MODULE)
# include <intrin.h> // _BitScanReverse[64], _BitScanForward[64], _umul128
#endif

Expand Down

0 comments on commit b4aea98

Please sign in to comment.