Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo: specify -> specific #6342

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Conversation

jamestwebber
Copy link
Contributor

What changes were proposed in this pull request?

Just fixing a grammatical error in the docs. Text said "in a specify imageSpec environment" instead of "in a specific imageSpec environment"

Signed-off-by: James Webber <[email protected]>
@jamestwebber jamestwebber requested a review from ppiegaze as a code owner March 16, 2025 18:42
Copy link

welcome bot commented Mar 16, 2025

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.50%. Comparing base (a767662) to head (6884aff).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6342   +/-   ##
=======================================
  Coverage   58.50%   58.50%           
=======================================
  Files         937      937           
  Lines       71107    71107           
=======================================
+ Hits        41598    41602    +4     
+ Misses      26356    26352    -4     
  Partials     3153     3153           
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.30% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.76% <ø> (+0.05%) ⬆️
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.00% <ø> (ø)
unittests-flytepropeller 54.82% <ø> (ø)
unittests-flytestdlib 64.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pingsutw pingsutw changed the title specify -> specific fix typo: specify -> specific Mar 20, 2025
@Sovietaced Sovietaced added the documentation Improvements or additions to documentation label Mar 23, 2025
@Sovietaced
Copy link
Contributor

Looks like there was a flaky build failure.

@Sovietaced
Copy link
Contributor

Thanks @jamestwebber

@Sovietaced Sovietaced merged commit 75b5ce3 into flyteorg:master Mar 23, 2025
51 checks passed
Copy link

welcome bot commented Mar 23, 2025

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants