Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] login to ghcr in CI #6329

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[WIP] login to ghcr in CI #6329

wants to merge 3 commits into from

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 11, 2025

Tracking issue

NA

Why are the changes needed?

To fix the failing tests. https://github.com/flyteorg/flyte/actions/runs/13793530918/job/38579909001?pr=6327

What changes were proposed in this pull request?

How was this patch tested?

unit tests

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw added the fixed For any bug fixes label Mar 11, 2025
@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw mentioned this pull request Mar 11, 2025
3 tasks
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.49%. Comparing base (22eaeab) to head (c8b27be).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6329       +/-   ##
===========================================
+ Coverage   33.82%   58.49%   +24.67%     
===========================================
  Files        1329      937      -392     
  Lines      147835    71091    -76744     
===========================================
- Hits        50004    41585     -8419     
+ Misses      92989    26354    -66635     
+ Partials     4842     3152     -1690     
Flag Coverage Δ
unittests-datacatalog 59.06% <ø> (+11.05%) ⬆️
unittests-flyteadmin 56.30% <ø> (+6.19%) ⬆️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.70% <ø> (+6.56%) ⬆️
unittests-flyteidl 76.12% <ø> (+69.33%) ⬆️
unittests-flyteplugins 61.00% <ø> (+11.98%) ⬆️
unittests-flytepropeller 54.80% <ø> (+18.27%) ⬆️
unittests-flytestdlib 64.02% <ø> (+13.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@pingsutw pingsutw marked this pull request as draft March 11, 2025 22:16
@pingsutw pingsutw changed the title login to ghcr in CI [WIP] login to ghcr in CI Mar 11, 2025
Signed-off-by: Kevin Su <[email protected]>
@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants