Support linting on go 1.23 #5690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5690 +/- ##
==========================================
- Coverage 36.17% 36.17% -0.01%
==========================================
Files 1302 1302
Lines 109582 109582
==========================================
- Hits 39645 39639 -6
- Misses 65797 65803 +6
Partials 4140 4140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This was a just test. We're not upgrading to go 1.23 any time. We can revisit this PR once we decide to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
golangci-lintadded support for go 1.23 in version 1.60.0.What changes were proposed in this pull request?
Bumped the golangci-lint version to 1.60.0.
Also, renamed
deadlinetotimeoutas the former was deprecated (as per golangci/golangci-lint#822).How was this patch tested?
Successfully ran
docker run --rm -it --workdir /code --volume $(pwd):/code golang:1.23.0-bookworm make -C flyteidl lintfrom root.Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link