calibration #44
Merged
calibration #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added service to request calibration data
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
flynneva
reviewed
Feb 2, 2022
| @@ -40,6 +40,7 @@ | |||
| from rclpy.qos import QoSProfile | |||
| from sensor_msgs.msg import Imu, MagneticField, Temperature | |||
| from std_msgs.msg import String | |||
| from example_interfaces.srv import Trigger | |||
There was a problem hiding this comment.
@Towflos we should probably add example_interfaces as a dependency to the package.xml then, right?
|
@Towflos wow this is a great feature! adding a service to calibrate the IMU. Do you think you could add a short section to the |
|
@flynneva the service only reads the calibration values and returns them in a message. I added the command to call the service to the |
|
@Towflos great stuff again, well done 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22 added mag_radius and acc_radius to parameters, added Trigger service to request calibration data