Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibration #44

Merged
merged 8 commits into from
Feb 3, 2022
Merged

calibration #44

merged 8 commits into from
Feb 3, 2022

Conversation

Towflos
Copy link

@Towflos Towflos commented Feb 2, 2022

#22 added mag_radius and acc_radius to parameters, added Trigger service to request calibration data

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou for creating your first PR! Contributions like yours is what it is all about. Keep it up!

@flynneva flynneva self-requested a review February 2, 2022 17:16
@@ -40,6 +40,7 @@
from rclpy.qos import QoSProfile
from sensor_msgs.msg import Imu, MagneticField, Temperature
from std_msgs.msg import String
from example_interfaces.srv import Trigger
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Towflos we should probably add example_interfaces as a dependency to the package.xml then, right?

@flynneva
Copy link
Owner

flynneva commented Feb 2, 2022

@Towflos wow this is a great feature! adding a service to calibrate the IMU. Do you think you could add a short section to the README on you expect people to use the service?

@Towflos
Copy link
Author

Towflos commented Feb 3, 2022

@flynneva the service only reads the calibration values and returns them in a message. I added the command to call the service to the README.

@flynneva flynneva merged commit cf7202c into flynneva:develop Feb 3, 2022
@flynneva
Copy link
Owner

flynneva commented Feb 3, 2022

@Towflos great stuff again, well done 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants