Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slurm: wait for all nodes being ready #786

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

dpausp
Copy link
Member

@dpausp dpausp commented Sep 18, 2023

Implement ready_many similar to drain_many which waits until the desired state is reached, with a configurable timeout. If nodes failed to become ready, they are reported in the timeout exception. Usually we expect the nodes to become ready almost immediately so there shouldn't be a noticeable waiting period.

ready_many is now used by the all-nodes ready subcommand.

PL-131739

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

  • slurm: the fc-slurm all-nodes ready command which is used by our automated maintenance system now waits for the nodes to actually become ready by checking their reported state (PL-131739).

Security implications

  • Security requirements defined? (WHERE)
    • availability: make sure that the node state reported by slurm matches the expected state
  • Security requirements tested? (EVIDENCE)
    • checked in the test slurm cluster that ready all terminates properly when nodes are ready
    • automated test checks normal execution and timeout

Implement ready_many similar to drain_many which waits until the
desired state is reached, with a configurable timeout. If nodes
failed to become ready, they are reported in the timeout exception.
Usually we expect the nodes to become ready almost immediately so
there shouldn't be a noticeable waiting period.

ready_many is now used by the `all-nodes ready` subcommand.

PL-131739
@dpausp dpausp marked this pull request as ready for review September 18, 2023 19:30
@dpausp dpausp force-pushed the PL-131739-slurm-ready-all-wait branch from e4ecf23 to c553bef Compare September 18, 2023 20:14
@dpausp dpausp merged commit 1c7641d into fc-23.05-dev Sep 28, 2023
@dpausp dpausp deleted the PL-131739-slurm-ready-all-wait branch September 28, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants