Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] Fix RIB monitoring script to handle unspecified address as next hop #1181

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

sysvinit
Copy link
Member

The BGP implementation in Nokia SR Linux sends the unspecified address :: as the next hop for IPv4-via-IPv6 routes on BGP sessions with NixOS hosts. FRR interprets this correctly, however this causes the monitoring script to incorrectly report an error. This change updates the monitoring script to handle this special case properly.

PL-133199

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • Monitoring correctness.
  • Security requirements tested? (EVIDENCE)
    • Tested manually on a machine in DEV, manually verified the Hydra tests pass.

Some BGP implementations, such as the one in Nokia SR Linux, will send
the unspecified address as the nexthop in IPv4-via-IPv6 routes, in
which case we should use the peer address as the nexthop instead.

PL-133199
@sysvinit sysvinit force-pushed the PL-133199-rib-monitor-nokia-nexthop branch from a23777d to 77eb14e Compare November 27, 2024 10:29
@osnyx osnyx merged commit 29d5e96 into fc-21.05-dev Nov 27, 2024
2 checks passed
@osnyx osnyx deleted the PL-133199-rib-monitor-nokia-nexthop branch November 27, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants