Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a32nx/pfd): Fix baro radio text rendering overlapped #9647

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MrJigs7
Copy link

@MrJigs7 MrJigs7 commented Dec 11, 2024

Fixes #9546

Summary of Changes

Added MappedSubject to handle rendering X position correctly depending on if noDhSelected true\false
Added alignment classes depending on if noDhSelected true\false
Added alignment to MdaDhValue
Updated X pos of mdaDhMode
Updated X pos of MdaDhValue

Screenshots (if necessary)

PicAfterChange

References

395319813-1bc79454-2d5c-4507-a952-d575ce4bbccf

Additional context

Discord username (if different from GitHub): MrJigs

Testing instructions

  1. Load aircraft, flightplan, weights etc
  2. Depart and activate APPR phase
  3. Enter baro decision altitude on APPR page, check display
  4. Enter radio decision height on APPR page, check display
  5. Fly approach with neither baro or radio minimums set to check no dh

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@Benjozork Benjozork added PFD Issue is related to the PFD A32NX Related to the A32NX aircraft labels Dec 12, 2024
@beheh
Copy link
Member

beheh commented Dec 12, 2024

@MrJigs7 Thanks for your contribution!

Could you please provide a better reference screenshot? The one you've sent is clearly from a simulator. Note that even Level D sims often get things wrong, so nothing beats a photo out of a real aircraft.

@MrJigs7
Copy link
Author

MrJigs7 commented Dec 12, 2024

I actually struggled a little bit to get 1 definitive reference photo. So I used a combination of a number of photos that I could find as well as these 2 videos here

https://youtu.be/4zK9jswncFQ?si=rccABZ1F5fxzPZDm
https://youtu.be/HGt17GU1wCk?si=jpngyyXvOhNg1z2M

@tracernz
Copy link
Member

The reference pic provided does not match the real aircraft. Real:
image
image

@MrJigs7
Copy link
Author

MrJigs7 commented Dec 12, 2024

Thanks for the pics, will double check my X pos against these and see if any adjustments are needed

@MrJigs7
Copy link
Author

MrJigs7 commented Dec 12, 2024

I've made a change to x and y pos based on the ref pic from Tracer and also updated this PR with new screenshot and the ref pics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft Needs Reference PFD Issue is related to the PFD
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

Switching between baro to radio minimums causes overlaps
5 participants