Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/oans): Handle single-digit runway identifiers #9603

Merged

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Nov 29, 2024

Fixes #9411

Summary of Changes

Fixes AMDB data for single-digit runway identifiers.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Perform a BTV landing on a runway with a single-digit identifier (e.g. KLAX 9L). BTV should perform as expected.
Try playing around with multiple runway selections in PLAN mode, to make sure the green arrow and cyan selection boxes behave correctly.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added A380X Related to the A380X aircraft QA A380 Only QA only for A380 required labels Nov 29, 2024
@flogross89 flogross89 added this to the v0.13.0 milestone Nov 29, 2024
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you did it! Nice :D

@flogross89
Copy link
Contributor Author

Quality Assurance Tester Report

Discord Username : floridude
Object of testing : #9603
Aircraft : A380X
Tier of Testing : 1
Date : 06/01/2025

Testing Process:
Performed BTV landing in EDDM (08R) and KLAX (7R) ✔️
Changed airports, selected different runways and exits in PLAN mode ✔️

Testing Results:
Passed

@flogross89 flogross89 enabled auto-merge (squash) January 6, 2025 03:36
@flogross89 flogross89 merged commit 074143e into flybywiresim:master Jan 6, 2025
8 checks passed
denmax18 added a commit to denmax18/A388x that referenced this pull request Jan 6, 2025
@flogross89 flogross89 deleted the fix-a380x-oans-merica-rwys branch January 8, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Passed
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

BTV/FMS RWY DISAGREE despite no actual difference
2 participants