-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x/mfd): add ATCCOM D-ATIS page #9535
base: master
Are you sure you want to change the base?
feat(a380x/mfd): add ATCCOM D-ATIS page #9535
Conversation
* Add layout for D-ATIS page * Add icon elements for D-ATIS page
Hello, is it possible to download your work to test it? Thank you |
The ATSU and router code isn't functional yet so there is no real function to test at the moment. This is only an early layout/ui logic implementation. |
* Add D-ATIS Received page * Tweak IconButton to make icon size scalable by adding the viewBox prop. Icon size still defaults to 35px to maintain compatibility with existing buttons.
* clean up layout code
Initial layout completed. INOP overlay similar to CONNECT page was implemented until full function is implemented. Will be following up with a logic PR after additional systems are completed. There is a tweak needed for the tab sizes/overlapping that will be done in a separate PR instead to facilitate QA testing. |
fbw-a380x/src/systems/instruments/src/MFD/pages/ATCCOM/DAtisBlock.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
Fixes #[issue_no]
Summary of Changes
To implement D-ATIS page in the ATC COM. This will focus on the layout and some basic UI functionality to prepare for ATSU implementation.
Screenshots (if necessary)
References
https://www.youtube.com/watch?v=AI8yFhuEa4Q&t=5375s
Additional context
Discord username (if different from GitHub): Heclak
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.