- 
                Notifications
    
You must be signed in to change notification settings  - Fork 76
 
Add backup config management to flexctl #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            16 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      01c1575
              
                Stub out commands for config management.
              
              
                ndarilek 0934148
              
                Get `flexctl backup config show` working.
              
              
                ndarilek 77ed090
              
                Get `flexctl backup config update` working.
              
              
                ndarilek 5cbf8dc
              
                gofmt
              
              
                ndarilek 3c89354
              
                Appease our linter overlords.
              
              
                ndarilek 9c23529
              
                Probably not necessary to close these as they're short-lived.
              
              
                ndarilek 74d382d
              
                Retrieve flag values separately.
              
              
                ndarilek 1bf8a12
              
                Style fixes.
              
              
                ndarilek cfb4655
              
                Construct URL from app environment.
              
              
                ndarilek c40d8e8
              
                Cosmetic changes.
              
              
                ndarilek 7987ec7
              
                Print restart instructions if required.
              
              
                ndarilek 4a90876
              
                Fix restart command.
              
              
                ndarilek c77ff26
              
                Switch from `fly app restart` to `fly pg restart`.
              
              
                ndarilek ffcc75f
              
                Cosmetic updates.
              
              
                ndarilek 7bbc400
              
                Check that backups are enabled before updating backup configs.
              
              
                ndarilek 06d9e36
              
                Add missing newline.
              
              
                ndarilek File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To future proof this, we could consider just pretty printing the json output. However, I think this is totally fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth on this but came to the same conclusion. If we make it more unwieldy, I'm happy to switch it later, or if you think we should do it now then I can.