Skip to content

Conversation

@DAlperin
Copy link
Contributor

Will fix to use replication slots later this is just a quick mvp

@DAlperin
Copy link
Contributor Author

Tested by:

  1. Setting up two node cluster: one primary, one standby
  2. Set timeout to 1 minute instead of default 10
  3. Kill standby
  4. Verify standby no longer present in cluster after 1 minute
  5. Restart standby and verify it cleanly rejoins cluster

I've decided to start writing down some test steps for myself to hopefully make writing integration tests easier eventually

Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note, but overall looks good!

@DAlperin DAlperin merged commit c05e48c into master Dec 22, 2022
@davissp14 davissp14 deleted the remove_standbys branch February 25, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants