Start supporting barman #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davissp14
reviewed
May 16, 2023
davissp14
reviewed
May 16, 2023
davissp14
reviewed
May 17, 2023
davissp14
reviewed
May 17, 2023
internal/flypg/ssh.go
Outdated
| return fmt.Errorf("failed to write cert: %s", err) | ||
| } | ||
|
|
||
| if err := writeSshConfig(); err != nil { |
There was a problem hiding this comment.
Nit: writeSSHConfig vs. writeSsh for consistency.
davissp14
reviewed
May 17, 2023
davissp14
reviewed
May 17, 2023
davissp14
requested changes
May 23, 2023
internal/flybarman/node.go
Outdated
| "github.com/fly-apps/postgres-flex/internal/flypg/admin" | ||
| ) | ||
|
|
||
| var dataDir = "/data" |
There was a problem hiding this comment.
You can just wrap this:
var (
dataDir = "/data"
barmanConfigFile = "..."
...
)
|
Any tests you can add for this would also be super helpful! |
|
@davissp14 added some tests for config and unified configs into the main node struct |
|
A release workflow appears to have been triggered, but no release has actually been created yet. Can you make a release for this? Creating a release helps me because I subscribe to it and regularly update the image by myself! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #90
MUST
Maybe okay to do later
fly pg restartunless a flag is passed and maybe make it restart for last