Let users scale a pg to zero #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to test this more to find a consistently good way to keep track of connection counts. |
|
I think I should ignore connections to the |
benbjohnson
requested changes
Apr 13, 2023
davissp14
approved these changes
Apr 13, 2023
cmd/start/main.go
Outdated
| if current > 1 { | ||
| continue | ||
| } | ||
| return errors.New("scale to zero condition hit") |
There was a problem hiding this comment.
Nit: Should just use fmt.Errorf here.
| } | ||
| } | ||
|
|
||
| func getCurrentConnCount(ctx context.Context, node *flypg.Node) (int, error) { |
There was a problem hiding this comment.
Nit: At some point this should be moved to the admin package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.