Remove the Miez first-run onboarding screen - #64
Merged
Conversation
Drops the MIEZ-8 welcome modal: the component, its tests, the root-route mount, and the ro/en strings it was the only consumer of. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
WalkthroughThe PR removes the Miez onboarding component, its tests, root-route integration, and first-run welcome translations in Romanian and English. ChangesMiez onboarding removal
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the MIEZ-8 welcome modal entirely.
What's removed
MiezOnboarding.tsx— the once-per-device, account-free three-beat pitch modalMiezOnboarding.test.tsx— its unit tests__root.tsxonboarding.miez.*ro/en strings, which the component was the only consumer ofVerification
tsc --noEmitinapps/web: no errorsvitest runinapps/web: 15 files, 79 tests passingMiezOnboarding/onboarding.miez/miez-onboardinganywhere underapps/*/srcorpackages/*/srcNote: devices that already dismissed the modal keep a stale
miez-onboarding-v1localStorage key. It's inert and harmless, so this PR leaves it rather than shipping cleanup code.🤖 Generated with Claude Code
Summary by CodeRabbit