Skip to content

hotfix hooks render order - #30

Merged
flvvius merged 1 commit into
mainfrom
feat/quiz
May 12, 2026
Merged

hotfix hooks render order#30
flvvius merged 1 commit into
mainfrom
feat/quiz

Conversation

@flvvius

@flvvius flvvius commented May 12, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Refactor
    • Reorganized internal logic in the quiz experience to improve code maintainability and clarity. No user-facing changes.

Review Change Stack

@vercel

vercel Bot commented May 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
news-web Building Building Preview, Comment May 12, 2026 1:57pm

@flvvius
flvvius merged commit 096630d into main May 12, 2026
1 of 4 checks passed
@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 091f92e8-d67e-4f78-b6ab-9c9b4cfff788

📥 Commits

Reviewing files that changed from the base of the PR and between 902cb8e and bffabf6.

📒 Files selected for processing (1)
  • apps/web/src/routes/quiz.tsx

Walkthrough

In QuizExperience, an authenticated early-return guard for the "today attempt" loading state is relocated. It originally executed before currentQuestion and related derived computations, but now executes after reviewByQuestionId memoization. The returned UI remains unchanged.

Changes

Loading State Guard Relocation

Layer / File(s) Summary
Relocate loading state early-return
apps/web/src/routes/quiz.tsx
The isAuthenticated && existingAttempt === undefined early-return is moved from before currentQuestion computation to after reviewByQuestionId derivation, preserving the same PageLoadingState UI props.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/quiz

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot mentioned this pull request May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant