Skip to content

Commit

Permalink
feat: both WasmWasi and WasmJS can be used together since Kotlin 2.0
Browse files Browse the repository at this point in the history
Signed-off-by: Artyom Shendrik <[email protected]>
  • Loading branch information
amal committed Dec 24, 2023
1 parent be688c9 commit 902d00f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
uses: github/codeql-action/upload-sarif@v2
continue-on-error: true
with:
sarif_file: fluxo-kmp-conf/build/reports/detekt/detekt.sarif
sarif_file: build/detekt-merged.sarif
category: detekt

- name: 'Run check-main'
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
### Added
- highlight publication setup in logs.
- verify that publication artifact version is set.
- both WasmWasi and WasmJS can be used together since Kotlin 2.0.

### Changed
- remove tests & checks from the `release` CI workflow.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,9 @@ internal class KmpConfigurationContainerDslImpl(
) {
wasmJs()

// Usage of both Wasi and JS targets lead to problems atm.
if (ENABLE_WASM_WASI && kotlinPluginVersion >= KOTLIN_1_9_20) {
// WASI target is available since Kotlin 1.9.20.
// Both WASI and JS can be used together since Kotlin 2.0.
if (ENABLE_WASM_WASI && kotlinPluginVersion >= KOTLIN_2_0) {
wasmWasi()
}
}
Expand All @@ -132,7 +133,8 @@ internal class KmpConfigurationContainerDslImpl(

// https://docs.gradle.org/current/userguide/validation_problems.html#implicit_dependency
private fun isGradleNotFailingOnImplicitTaskDependencies() =
GradleVersion.version(holder.project.gradle.gradleVersion) < GradleVersion.version("8.0")
GradleVersion.current() < GradleVersion.version("8.0")
}

private const val ENABLE_WASM_WASI = false

0 comments on commit 902d00f

Please sign in to comment.