git: Add support for sparse checkout #850
Conversation
kane8n
force-pushed
the
support-sparse-checkout
branch
from
732fc20 to
19f2318
Compare
stefanprodan
changed the title
Hey @kane8n, sparse checkout could be very useful in source-controller as well. PS. please run |
Signed-off-by: kane8n <[email protected]>
kane8n
force-pushed
the
support-sparse-checkout
branch
from
19f2318 to
ed54e74
Compare
|
Hey @pjbgf is sparse checkout stable in go-git, can it be used in IAC to commit changes back to the upstream branch? I'm reading the go-git code and I assume this can't work, especially when IAC needs to push a new branch. |
There was a problem hiding this comment.
Hey @pjbgf is sparse checkout stable in go-git, can it be used in IAC to commit changes back to the upstream branch? I'm reading the go-git code and I assume this can't work, especially when IAC needs to push a new branch.
@stefanprodan this would certainly be useful for SC. For IAC, it should also work however I haven't tested pushing from a repository that was sparse checkout using go-git. If that ends up being a problem, we have two options: fix the issue in go-git which we should be able to do at pace these days, or b) just opt-out of sparse checkout in IAC.
| name: "Default branch", | ||
| branch: "master", | ||
| filesCreated: map[string]string{"dir1/branch": "init1"}, | ||
| sparseCheckoutDirectories: []string{"dir1"}, |
There was a problem hiding this comment.
As the API enables multiple dirs to be set, we should add a test case that covers more than one dir
Add the sparse checkout option to the gogit package.
This change is in preparation for adding the sparse checkout option to ImageAutomationController.
Reference:
https://github.com/go-git/go-git/blob/master/_examples/sparse-checkout/main.go