tests/int: ECR force delete and use go 1.18 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS provider v4.22.0 changed the default force delete configuration of ECR to false, resulting in test cleanup failure. Set force_delete of ECR to true. Signed-off-by: Sunny <[email protected]>
Use aws region from terraform state in the login command. Minor improvements in the names used in the generated EKS kubeconfig. Signed-off-by: Sunny <[email protected]>
Signed-off-by: Sunny <[email protected]>
stefanprodan
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform AWS provider v4.22.0 changed the default force delete configuration of
ECR to false, resulting in test cleanup failure. Set force_delete of ECR
to true.
Refer: hashicorp/terraform-provider-aws#9913
Cleanup error:
Also, minor improvements in the names used in the generated EKS
kubeconfig and login command to use the correct region.
Update go.mod and go.sum for go 1.18